Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix params-in functionality in nf-core launch #1986

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 31, 2022

Skip the deletion step of --params_in, if --params_in == --params_out.

Fixes #1969.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

@mashehu mashehu requested review from ewels and mirpedrol October 31, 2022 10:58
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1986 (e0baf78) into dev (6bf8f30) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##              dev    #1986      +/-   ##
==========================================
- Coverage   62.01%   61.99%   -0.02%     
==========================================
  Files          42       42              
  Lines        4862     4865       +3     
==========================================
+ Hits         3015     3016       +1     
- Misses       1847     1849       +2     
Impacted Files Coverage Δ
nf_core/launch.py 63.45% <37.50%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashehu mashehu merged commit 53618a5 into nf-core:dev Nov 2, 2022
@mashehu mashehu deleted the fix-launch-params-in branch November 2, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants