Remove duplicate code #2053
Merged
Remove duplicate code #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirpedrol
approved these changes
Nov 25, 2022
Comment on lines
83
to
88
| if self.component_type == "modules": | ||
| installed_components = modules_json.get_all_modules().get(self.modules_repo.remote_url) | ||
| installed_components = modules_json.get_all_components(self.component_type).get( | ||
| self.modules_repo.remote_url | ||
| ) | ||
| elif self.component_type == "subworkflows": | ||
| modules_json.get_installed_subworkflows().get(self.modules_repo.remote_url) | ||
| modules_json.get_all_components(self.component_type).get(self.modules_repo.remote_url) |
There was a problem hiding this comment.
We can delete the if/else now and only use line 84
installed_components = modules_json.get_all_components(self.component_type).get(
self.modules_repo.remote_url
)
Codecov Report
@@ Coverage Diff @@
## dev #2053 +/- ##
==========================================
+ Coverage 67.63% 67.66% +0.03%
==========================================
Files 43 43
Lines 5558 5555 -3
==========================================
Hits 3759 3759
+ Misses 1799 1796 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was duplicated functionality being used which has been superseded by the generalised
ModulesJson.get_all_componentsPR checklist
CHANGELOG.mdis updateddocsis updated