Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always format modules.json after writing it #2074

Merged
merged 16 commits into from
Dec 5, 2022
Merged

Always format modules.json after writing it #2074

merged 16 commits into from
Dec 5, 2022

Commits on Nov 29, 2022

  1. format modules.json after dump

    @fabianegli
    fabianegli committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    422cda6 View commit details
    Browse the repository at this point in the history

  2. make module_json_path an attribute

    @fabianegli
    fabianegli committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    41e062b View commit details
    Browse the repository at this point in the history

  3. use the dump method to write the file

    @fabianegli
    fabianegli committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    41e3957 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. resolve variable and attribute name clash

    @fabianegli
    fabianegli committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    7b1aa28 View commit details
    Browse the repository at this point in the history

  2. warn instead of raise if pre-commit prettier fails

    @fabianegli
    fabianegli committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    59be867 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into format-in-modules-json-dump

    @fabianegli
    fabianegli authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    c19c7e6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into format-in-modules-json-dump

    @fabianegli
    fabianegli authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    620c905 View commit details
    Browse the repository at this point in the history

  5. Update nf_core/lint_utils.py 

    Change prettier syntax errors to issue a log instead of error out

Co-authored-by: Fabian Egli <fabianegli@users.noreply.github.com>
    @awgymer @fabianegli
    awgymer and fabianegli authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    3a5332e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' into format-in-modules-json-dump

    @fabianegli
    fabianegli authored Nov 30, 2022
    Configuration menu
    Copy the full SHA
    ec58342 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. add else after changing from raise to loggging

    @fabianegli
    fabianegli committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a2dd803 View commit details
    Browse the repository at this point in the history

  2. test new logging behavior

    @fabianegli
    fabianegli committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    2630a2a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into format-in-modules-json-dump

    @fabianegli
    fabianegli authored Dec 3, 2022
    Configuration menu
    Copy the full SHA
    cd63560 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. use pytest caplog for testing logging

    @fabianegli
    fabianegli committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    455b90d View commit details
    Browse the repository at this point in the history

  2. fix typo 

    Co-authored-by: awgymer <24782660+awgymer@users.noreply.github.com>
    @fabianegli @awgymer
    fabianegli and awgymer authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    5bc4212 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @fabianegli
    fabianegli authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    c695835 View commit details
    Browse the repository at this point in the history

  4. fix typo

    @fabianegli
    fabianegli authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    c98c5c7 View commit details
    Browse the repository at this point in the history