Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conda channel order to nextflow.config template #2094

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Dec 5, 2022

On hold until nextflow-io/nextflow#3435 is released

@mashehu mashehu requested a review from ewels December 5, 2022 10:49
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (225ef23) 73.23% compared to head (38779e9) 73.10%.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ewels ewels changed the title add conda channel order to nextflow.config template [on-hold] add conda channel order to nextflow.config template Dec 5, 2022
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mashehu and others added 2 commits December 5, 2022 12:46
@maxulysse
Copy link
Member

@maxulysse
Copy link
Member

Nevermind, I think it was merged in https://github.com/nextflow-io/nextflow/releases/tag/v22.11.1-edge.
So pretty sure it's not included in 22.10.7

@mashehu mashehu marked this pull request as ready for review January 9, 2024 07:48
@mashehu
Copy link
Contributor Author

mashehu commented Jan 9, 2024

This is now available in nextflow >= 23.04, which is the minimum version in the template

@mashehu mashehu requested a review from mirpedrol January 9, 2024 07:49
@mashehu
Copy link
Contributor Author

mashehu commented Jan 9, 2024

@nf-core-bot changelog Template: add conda channel order to nextflow.config

@mashehu mashehu changed the title [on-hold] add conda channel order to nextflow.config template add conda channel order to nextflow.config template Jan 9, 2024
@mashehu mashehu merged commit ccf1104 into nf-core:dev Jan 9, 2024
15 checks passed
@mashehu mashehu deleted the add-conda-defaults branch January 9, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants