Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down colour in successful completion but some failed processes #2096

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Dec 5, 2022

I've noted in some cases that people believe a pipeline has completely failed, even though a pipeline developer allows some processes to fail, because the final completion message is red.

This switches from Red to Yellow to make it less 'failurey'.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #2096 (45ea6cb) into dev (f0b6c48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2096   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files          43       43           
  Lines        5625     5625           
=======================================
  Hits         3826     3826           
  Misses       1799     1799           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jfy133 jfy133 merged commit d013299 into nf-core:dev Dec 7, 2022
@jfy133 jfy133 deleted the successful-with-error-colour-change branch December 7, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants