Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint pipeline name #2122

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Fix lint pipeline name #2122

merged 1 commit into from
Dec 12, 2022

Conversation

awgymer
Copy link
Contributor

@awgymer awgymer commented Dec 9, 2022

Fixes #2117

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @awgymer,

It looks like this pull-request is has been made against the awgymer/nf-core-tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the awgymer/nf-core-tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@awgymer awgymer closed this Dec 9, 2022
@awgymer awgymer reopened this Dec 9, 2022
@awgymer awgymer changed the base branch from master to dev December 9, 2022 22:24
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #2122 (a8cc7d9) into dev (3dc4052) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #2122   +/-   ##
=======================================
  Coverage   71.44%   71.44%           
=======================================
  Files          77       77           
  Lines        8351     8351           
=======================================
  Hits         5966     5966           
  Misses       2385     2385           
Impacted Files Coverage Δ
nf_core/create.py 64.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes nf-core lint from #2122 👍
But still doesn't fix errors with nf-core create and nf-core sync with pipelines created with dashed-names, see slack report of the bug. We should add a new argument to create() which allows names with dashes in not nf-core pipelines. This can be done in a different PR :)

@awgymer awgymer merged commit 94a03a1 into nf-core:dev Dec 12, 2022
@awgymer awgymer deleted the fix-lint-pipeline-name branch December 12, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to make the new workflow name checks optional
2 participants