Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .editorconfig #2145

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Update .editorconfig #2145

merged 3 commits into from
Apr 5, 2023

Conversation

maxulysse
Copy link
Member

I believe we removed the CITATIONS.cff file, right?

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

I believe we removed the CITATIONS.cff file, right?
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #2145 (f3eee2a) into dev (27318f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2145   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          78       78           
  Lines        8384     8384           
=======================================
  Hits         6122     6122           
  Misses       2262     2262           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏽Might be worth adding a line to the CHANGELOG.

@mirpedrol mirpedrol merged commit dbe488b into dev Apr 5, 2023
@mirpedrol mirpedrol deleted the maxulysse-patch-1 branch April 5, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants