Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the mulled command and all related code #2199

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Conversation

Midnighter
Copy link
Contributor

@Midnighter Midnighter commented Mar 12, 2023

Based on Slack discussion, we decided to completely remove the mulled command and its dependencies.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Merging #2199 (1bde222) into dev (4a29080) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2199      +/-   ##
==========================================
+ Coverage   71.57%   71.65%   +0.07%     
==========================================
  Files          77       76       -1     
  Lines        8369     8315      -54     
==========================================
- Hits         5990     5958      -32     
+ Misses       2379     2357      -22     
Impacted Files Coverage Δ
nf_core/__main__.py 59.80% <ø> (+0.98%) ⬆️
nf_core/modules/__init__.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mirpedrol
Copy link
Member

Should we also add a link to your app in the documentation?

@Midnighter
Copy link
Contributor Author

If you like, we can surely do that.

@mirpedrol
Copy link
Member

I have added the link to the documentation nf-core/website#1743 and will merge this if that's ok @Midnighter

@Midnighter
Copy link
Contributor Author

Please go ahead, yes ☺️

@mirpedrol mirpedrol merged commit f1fc15b into dev Apr 5, 2023
@mirpedrol mirpedrol deleted the rm-mulled branch April 5, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants