Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apptainer profile #2245

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Add apptainer profile #2245

merged 3 commits into from
Apr 21, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Apr 21, 2023

Add apptainer profile as now supported by NXF (I think added by @matthdsm into the main NXF repo?)

Closes #2244

(More info: https://www.nextflow.io/docs/latest/container.html note website broken so apptainer section missing header, but will be fixed soon)

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay I think!
PS: requested by me, not added

@jfy133
Copy link
Member Author

jfy133 commented Apr 21, 2023

You were involved

image

;)

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2245 (af5bc1b) into dev (ca9a506) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2245   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files          77       77           
  Lines        8344     8344           
=======================================
  Hits         6095     6095           
  Misses       2249     2249           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jfy133 jfy133 requested a review from mashehu April 21, 2023 11:41
@jfy133 jfy133 merged commit fa05c3c into dev Apr 21, 2023
@jfy133 jfy133 deleted the add-apptainer-support branch April 21, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants