GitPod base image: Always self-update to the latest version of Nextflow. #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: @mirpedrol added the Nextflow pin in #2196 with the logic that we should install the minimum supported version of Nextflow. This PR is inverting that logic and trying to have the latest available version. I feel that this is better, as this image is mostly used for development work but also some people seem to use it for actually running pipelines as well. Having the latest version will ensure that relevant bugfixes are included, and saves us a task for remembering to keep it up to date. |
Codecov Report
@@ Coverage Diff @@
## dev #2274 +/- ##
=======================================
Coverage 73.11% 73.11%
=======================================
Files 77 77
Lines 8432 8432
=======================================
Hits 6165 6165
Misses 2267 2267 |
mirpedrol
approved these changes
May 4, 2023
mashehu
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some issues where the GitPod Nextflow version is behind the stable release, and doesn't include important bugfixes and changes. It's difficult to remember to bump the version there manually every time. This PR makes sure that the latest stable version is in the image automatically.
nextflow self-updateas part of the build process, in case bioconda is not up to date