Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove-tracedir-param #2290

Merged
merged 2 commits into from
Jun 29, 2023
Merged

remove-tracedir-param #2290

merged 2 commits into from
Jun 29, 2023

Conversation

sateeshperi
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #2290 (94dcf28) into dev (df428cb) will increase coverage by 0.48%.
The diff coverage is n/a.

❗ Current head 94dcf28 differs from pull request most recent head 1bf8d1c. Consider uploading reports for the commit 1bf8d1c to get more accurate results

@@            Coverage Diff             @@
##              dev    #2290      +/-   ##
==========================================
+ Coverage   72.64%   73.12%   +0.48%     
==========================================
  Files          78       77       -1     
  Lines        8853     8433     -420     
==========================================
- Hits         6431     6167     -264     
+ Misses       2422     2266     -156     

see 23 files with indirect coverage changes

@mashehu
Copy link
Contributor

mashehu commented May 13, 2023

What's the motivation for this change?

@sateeshperi
Copy link
Contributor Author

#2208

@sateeshperi sateeshperi added the WIP Work in progress label May 13, 2023
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should hopefully be fine: #2208 (comment)

@sateeshperi sateeshperi removed the WIP Work in progress label Jun 26, 2023
@sateeshperi sateeshperi self-assigned this Jun 26, 2023
@ewels ewels added this to the 2.9 milestone Jun 29, 2023
@mirpedrol mirpedrol merged commit 1d7c39c into dev Jun 29, 2023
@mirpedrol mirpedrol deleted the fix/2208-remove-tracedir branch June 29, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants