Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add d to the pattern of max_time #2304

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

nvnieuwk
Copy link
Contributor

@nvnieuwk nvnieuwk commented Jun 8, 2023

When params.max_time is set to 72.h for example, Nextflow converts that to 3d which doesn't match the current pattern when using the nf-validation plugin.

The following invalid input values have been detected:

* --max_time: string [3d] does not match pattern ^(\d+\.?\s*(s|m|h|day)\s*)+$ (3d)

This PR fixes that issue

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2304 (e74f588) into dev (646a566) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2304   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files          78       78           
  Lines        8732     8732           
=======================================
  Hits         6372     6372           
  Misses       2360     2360           

@nvnieuwk
Copy link
Contributor Author

nvnieuwk commented Jun 8, 2023

Is it okay to merge with that failing test?

@mirpedrol
Copy link
Member

Yes for this one, it's on the Nextflow side, and they are already aware of it :)

@nvnieuwk nvnieuwk merged commit 711d074 into nf-core:dev Jun 8, 2023
@nvnieuwk nvnieuwk deleted the fix-max_time-template branch June 8, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants