-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tower UI no longer shows revisions for downloaded pipelines. #2308
Conversation
…ularity_cachedir_remote()
…). Type error, because it needs to be callable and not a plain string.
This PR is against the
|
Codecov Report
@@ Coverage Diff @@
## dev #2308 +/- ##
==========================================
- Coverage 72.97% 72.89% -0.08%
==========================================
Files 78 78
Lines 8732 8756 +24
==========================================
+ Hits 6372 6383 +11
- Misses 2360 2373 +13
|
nf_core/download.py
Outdated
# "latest" is neither a branch (no heads exist) nor a tag, since is_valid_object() returned False. | ||
# try to determine highest contained version number from desired revisions, to which latest will be pinned. | ||
try: | ||
latest = sorted(desired_revisions, key=StrictVersion, reverse=True)[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't you use looseversion
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
distutils
module is unfortunately deprecated. Will therefore rewrite and use neither StrictVersion
nor LooseVersion
. Took a simplified Regex derived from the one in PEP386.
3f8270a
to
d84a43b
Compare
…odule is deprecated. See PEP 632 and PEP 386 for details.
d84a43b
to
8abe1a6
Compare
Fix for issue #2307 and some other bugs discovered along the way:
latest
branch to ensure that there is at least one branch in the repo. It will use the tag with the highest semantic version number. Otherwise, Tower's UI will fail to display the revisions.TypeError
inprompt_singularity_cachedir_remote()
. In the documentation, I had missed that a validationstr
must be wrapped into a callable object. Now,SingularityCacheFilePathValidator
inutils.py
handles the validation of the interactive input to--singularity-cache-index
.read_remote_containers()
, I had missed that a call toprompt_singularity_cachedir_remote()
still used theretry
argument, even though I removed this argument from the final version of the function, because @mashehu had recommended a better way to implement the behaviour.find_container_images()
I had denoted a logical and as&
even though Python usesand
.prompt_singularity_cachedir_remote()
andsummary_log
, I have rephrased two messages to the user.PR checklist
CHANGELOG.md
is updated (Not required, since there had not been a release yet of the buggy code.)docs
is updated