Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom registry to nfcore modules lint #2313

Merged

Conversation

adamrtalbot
Copy link
Contributor

Adds ability to set custom --registry to modules lint. Default to quay.io. Based on #2306 so requires that to be merged first.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Changes:
 - Adds --registry parameter to nf-core modules lint
 - Will check container definition via this registry
 - Default to quay.io
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #2313 (f63afd2) into dev (59d2309) will decrease coverage by 0.03%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##              dev    #2313      +/-   ##
==========================================
- Coverage   72.89%   72.87%   -0.03%     
==========================================
  Files          78       78              
  Lines        8760     8760              
==========================================
- Hits         6386     6384       -2     
- Misses       2374     2376       +2     
Impacted Files Coverage Δ
nf_core/modules/lint/__init__.py 83.41% <85.71%> (ø)
nf_core/__main__.py 57.25% <100.00%> (+0.16%) ⬆️
nf_core/modules/lint/main_nf.py 68.28% <100.00%> (ø)

... and 3 files with indirect coverage changes

tests/modules/lint.py Show resolved Hide resolved
@adamrtalbot adamrtalbot merged commit 3de58f2 into nf-core:dev Jun 15, 2023
@adamrtalbot adamrtalbot deleted the add_custom_registry_to_nfcore_modules_lint branch June 15, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants