Fix linting when creating a pipeline skipping some parts of the template #2330
Conversation
mirpedrol
changed the title
| @@ -446,6 +469,10 @@ def fix_linting(self): | |||
| if not self.template_params["github_badges"] or not self.template_params["github"]: | |||
| lint_config["readme"] = ["nextflow_badge"] | |||
|
|
|||
| # If the pipeline is unbranded | |||
| if not self.template_params["branded"]: | |||
| lint_config["files_unchanged"].extend([".github/ISSUE_TEMPLATE/bug_report.yml"]) | |||
There was a problem hiding this comment.
If we can avoid just flat out ignoring this file, that would be nice. There is already a function to customise it to remove some nf-core specific stuf. I think the failure on this file is something to do with the custom prefix / name match at the end of the output.
There was a problem hiding this comment.
When the pipeline is unbranded we remove one chunk of this file containing links to nf-core documentation:
- type: markdown
attributes:
value: |
Before you post this issue, please check the documentation:
- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
- [{{ name }} pipeline documentation](https://nf-co.re/{{ short_name }}/usage)so it won't match the template, and can't be considered a partial match either.
There was a problem hiding this comment.
so it won't match the template, and can't be considered a partial match either.
Seems like this isn't possible so will merge this in and we can follow up in a separate PR / issue if required.
mirpedrol
force-pushed
the
fix-linting-create-template
branch
from
fd34e7a
to
56ca280
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2330 +/- ##
==========================================
+ Coverage 72.86% 73.07% +0.21%
==========================================
Files 78 78
Lines 8777 8769 -8
==========================================
+ Hits 6395 6408 +13
+ Misses 2382 2361 -21
|
There was a problem hiding this comment.
Tested your branch and the linting is now working for me @mirpedrol . Will approve and wait for @ewels to comment on his comment.
Fix linting when createing a pipeline skipping some parts of the template
Close #2329
PR checklist
CHANGELOG.mdis updateddocsis updated