Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download: Add apptainer to the list of false positve container strings #2353

Merged

Conversation

MatthiasZepper
Copy link
Member

Add apptainer keyword to the list of false positive matches. Bare minimum to possibly support a future apptainer.registry notation in the container specifications ?

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

…imum to possibly support a future apptainer.registry notation.
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #2353 (d2b8a45) into dev (cdf620e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d2b8a45 differs from pull request most recent head 464f2fb. Consider uploading reports for the commit 464f2fb to get more accurate results

@@            Coverage Diff             @@
##              dev    #2353      +/-   ##
==========================================
- Coverage   72.76%   72.75%   -0.02%     
==========================================
  Files          78       78              
  Lines        8889     8889              
==========================================
- Hits         6468     6467       -1     
- Misses       2421     2422       +1     
Impacted Files Coverage Δ
nf_core/download.py 59.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

@MatthiasZepper MatthiasZepper merged commit d74b909 into nf-core:dev Jun 30, 2023
@MatthiasZepper MatthiasZepper deleted the ContainerErrorDifferentialAbundance branch June 30, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants