Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --no-git option from pipeline create command #2394

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Aug 11, 2023

Removing the --no-git option from nf-core create.
The argument is maintained as it is used by other commands such as sync and several tests
Close #2081

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #2394 (4836eda) into dev (df0c1bf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2394      +/-   ##
==========================================
- Coverage   71.09%   71.09%   -0.01%     
==========================================
  Files          87       87              
  Lines        9410     9409       -1     
==========================================
- Hits         6690     6689       -1     
  Misses       2720     2720              
Files Changed Coverage Δ
nf_core/__main__.py 57.07% <100.00%> (-0.07%) ⬇️

@mirpedrol mirpedrol marked this pull request as ready for review August 11, 2023 11:33
@mirpedrol mirpedrol merged commit 244e090 into nf-core:dev Aug 11, 2023
20 checks passed
@mirpedrol mirpedrol deleted the deprecate-no-git branch August 11, 2023 12:34
@mirpedrol mirpedrol restored the deprecate-no-git branch November 3, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants