Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apptainer automounts #2415

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Add apptainer automounts #2415

merged 2 commits into from
Sep 7, 2023

Conversation

sofstam
Copy link
Contributor

@sofstam sofstam commented Sep 7, 2023

This PR adds autoMounts in apptainer.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@LilyAnderssonLee
Copy link

Is it necessary to keep singularity.autoMounts=True when apptainer.autoMounts=true has been set within the apptainer profile? It will take precedence when you use the apptainer profile to run your workflow, right?

@maxulysse
Copy link
Member

singularity.autoMounts=True is in the singularity profile, so no issue there

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #2415 (f0ab665) into dev (f71a22a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2415   +/-   ##
=======================================
  Coverage   71.07%   71.07%           
=======================================
  Files          87       87           
  Lines        9431     9431           
=======================================
  Hits         6703     6703           
  Misses       2728     2728           

@sofstam
Copy link
Contributor Author

sofstam commented Sep 7, 2023

Will merge :)

@sofstam sofstam merged commit b767afe into nf-core:dev Sep 7, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants