Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated devcontainer.json permissions for using devcontainers in Codespaces/VS Code #2422

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

CarsonJM
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@CarsonJM CarsonJM self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2422 (0338dfe) into dev (6483100) will decrease coverage by 0.39%.
Report is 3 commits behind head on dev.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #2422      +/-   ##
==========================================
- Coverage   71.07%   70.69%   -0.39%     
==========================================
  Files          87       87              
  Lines        9431     9431              
==========================================
- Hits         6703     6667      -36     
- Misses       2728     2764      +36     

see 1 file with indirect coverage changes

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirpedrol mirpedrol merged commit b2fdc4e into nf-core:dev Sep 25, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants