-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support remote paths in NfCoreTemplate:dump_parameters #2465
support remote paths in NfCoreTemplate:dump_parameters #2465
Conversation
ce457a2
to
86bfec9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #2465 +/- ##
=======================================
Coverage 70.60% 70.60%
=======================================
Files 87 87
Lines 9437 9435 -2
=======================================
- Hits 6663 6662 -1
+ Misses 2774 2773 -1 |
Thanks for reporting, I see the issue, but I was wondering why the code does not work as I copied it from here and as far as I know, we are not encountering the same issue, maybe @mirpedrol can help here... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test this with S3, but code looks good, if you tested it LGTM :)
f1a99a8
to
5ec389e
Compare
Currently the new
dump_parameters
added in v2.10 (#2425) only works on local files.When using a remote publish dir such as s3, the json file will be written to a weird directory
s3 / path / to / outdir / params_{timestamp}.json
in the launchDir.This small tweak first creates the parameter dump on the nextflow head machine as a hidden file and then moves it to the possibly remote outdir using the nextflow FilesEx helper to deal with the remote filesystems.
PR checklist
CHANGELOG.md
is updateddocs
is updated