Ignore process selector warnings by default #2472
Conversation
There was a problem hiding this comment.
Could you also modify the documentation in CONTRIBUTING.md? Otherwise, looks good! :)
And after this PR you can also add the documentation to the website, contributing documentation is here
| @@ -216,6 +217,9 @@ env { | |||
| // Capture exit codes from upstream processes when piping | |||
| process.shell = ['/bin/bash', '-euo', 'pipefail'] | |||
|
|
|||
| // Disable process selector warnings by default. Use debug profile to enable warnings. | |||
| nextflow.enable.configProcessNamesValidation = false | |||
There was a problem hiding this comment.
No need to add this param in the global scope
There was a problem hiding this comment.
Thanks for the review!
- I've added these notes to the website - does it look okay? https://github.com/nf-core/website/pull/2040/files
- I will work on CONTRIBUTING.md
There was a problem hiding this comment.
No need to add this param in the global scope
The default for this setting in nextflow is true. My idea for this is to set it to false by default [edit: this is why I used global scope], then return it to true if using debug. I can add it to a different scope, do you have a recommendation on that?
There was a problem hiding this comment.
yes, sorry I missed that it was true by default. Your code looks good then
|
I've added the same text in CONTRIBUTING.md, so it should be ready to go when the test is done :) |
Thanks! It seems to be failing due to rate limiting on some of the APIs used by the tests. pytest has passed on one platform, Python 3.11, but not the others. Is it okay to merge then? |
|
I've re-run the failed tests, let's see if they pass now |
Codecov Report
@@ Coverage Diff @@
## dev #2472 +/- ##
==========================================
- Coverage 70.60% 70.57% -0.03%
==========================================
Files 87 87
Lines 9437 9421 -16
==========================================
- Hits 6663 6649 -14
+ Misses 2774 2772 -2 |
PR checklist
CHANGELOG.mdis updateddocsis updatedThis addresses issue #2161.
Changes nextflow.config in the template to set
nextflow.enable.configProcessNamesValidation = false. Thedebugprofile can then be used to re-enable these warnings.The pull request template is updated to include a "testing with
debugprofile" step.I will also send a PR for the website (docs).