-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lint test to check existence of test profile #2478
Conversation
2efda30
to
0cf3fbd
Compare
0cf3fbd
to
6c0325f
Compare
The test is now parsing nextflow.config to verify the existence of the |
Codecov Report
@@ Coverage Diff @@
## dev #2478 +/- ##
==========================================
- Coverage 70.71% 70.63% -0.08%
==========================================
Files 87 87
Lines 9424 9461 +37
==========================================
+ Hits 6664 6683 +19
- Misses 2760 2778 +18
|
we added a new type checker for python code, which unfortunately is still a bit too aggressive. you can ignore that specific test for now. |
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
PR checklist
CHANGELOG.md
is updateddocs
is updatedThis is the first part of #1837.
See below comment: The following is no longer true (no way to "strike through" in github?):
It is not an ideal implementation, because it has to call
nextflow
, and only gets indirect indication of the failure due to the exit code. If there's a better way to reliably parse the config with python, I will use that instead- I hope someone can offer guidance on that if possible.This is a draft PR, not ready for merge.