Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code in preparation of a future 'subworkflows patch' command #2482

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Refactor code in preparation of a future 'subworkflows patch' command #2482

merged 8 commits into from
Oct 23, 2023

Conversation

bjlang
Copy link
Contributor

@bjlang bjlang commented Oct 18, 2023

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@bjlang bjlang changed the title Dev Refactor code in preparation of a future 'subworkflows patch' command Oct 18, 2023
@bjlang bjlang marked this pull request as ready for review October 18, 2023 10:37
@bjlang bjlang requested a review from mirpedrol October 18, 2023 10:44
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #2482 (bf77d88) into dev (3fddb70) will increase coverage by 0.04%.
The diff coverage is 79.81%.

@@            Coverage Diff             @@
##              dev    #2482      +/-   ##
==========================================
+ Coverage   70.53%   70.58%   +0.04%     
==========================================
  Files          87       88       +1     
  Lines        9456     9478      +22     
==========================================
+ Hits         6670     6690      +20     
- Misses       2786     2788       +2
Files Coverage Δ
nf_core/modules/patch.py 100.00% <100.00%> (+20.95%) ⬆️
nf_core/components/patch.py 79.04% <79.04%> (ø)

... and 7 files with indirect coverage changes

mirpedrol
mirpedrol approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to update the CHANGELOG.md before merging!

@bjlang
Copy link
Contributor Author

bjlang commented Oct 23, 2023

@nf-core-bot fix linting

@bjlang bjlang merged commit 3475626 into nf-core:dev Oct 23, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjlang @mirpedrol @nf-core-bot