Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PyUpgrade in pre-commit #2483

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Implement PyUpgrade in pre-commit #2483

merged 7 commits into from
Dec 15, 2023

Conversation

kedhammar
Copy link
Contributor

  • Add PyUpgrade to pre-commit config and dev requirements.
  • CHANGELOG.md is updated

@kedhammar
Copy link
Contributor Author

Mentioned in #2200

@kedhammar kedhammar self-assigned this Oct 18, 2023
@kedhammar kedhammar linked an issue Oct 18, 2023 that may be closed by this pull request
Add type annotations to nf-core/tools #2200
Closed
3 tasks
@kedhammar kedhammar mentioned this pull request Oct 18, 2023
Closed
3 tasks
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9414faf) 75.05% compared to head (6c2bcb3) 75.05%.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2483   +/-   ##
=======================================
  Coverage   75.05%   75.05%           
=======================================
  Files          85       85           
  Lines        9371     9371           
=======================================
  Hits         7033     7033           
  Misses       2338     2338

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fabianegli
fabianegli reviewed Oct 18, 2023
View reviewed changes
requirements-dev.txt Outdated Show resolved Hide resolved
fabianegli
fabianegli reviewed Oct 18, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
fabianegli
fabianegli requested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@fabianegli fabianegli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Pyupgrade not to introduce changes incompatible with our supported Python versions, it requires the flag indicating the oldest supported Python version.

mirpedrol and others added 2 commits December 15, 2023 09:40
@mirpedrol @fabianegli
Apply suggestions from code review
a6216a7 
Co-authored-by: Fabian Egli <fabianegli@users.noreply.github.com>
@mirpedrol
Merge branch 'dev' into pyupgrade
50a68aa
@mirpedrol
Copy link
Member

@nf-core-bot fix linting

@mirpedrol
Copy link
Member

@fabianegli are you happy to merge this once tests pass?

@fabianegli fabianegli merged commit 4300381 into nf-core:dev Dec 15, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@fabianegli fabianegli fabianegli approved these changes

Assignees

@kedhammar kedhammar

Labels
enhancement infrastructure linting
Projects
Hackathon: November 2023
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type annotations to nf-core/tools
5 participants
@kedhammar @mirpedrol @mashehu @fabianegli @nf-core-bot