Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add closure to multiqc ext.args #2509

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Add closure to multiqc ext.args #2509

merged 4 commits into from
Nov 9, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

ewels
ewels approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but 👉🏻 changelog :)

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

Merging #2509 (faa2c06) into dev (ecdb55b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2509   +/-   ##
=======================================
  Coverage   70.50%   70.50%           
=======================================
  Files          88       88           
  Lines        9515     9515           
=======================================
  Hits         6709     6709           
  Misses       2806     2806

@maxulysse maxulysse merged commit 4ed0587 into dev Nov 9, 2023
19 checks passed
@maxulysse maxulysse deleted the maxulysse-patch-2 branch November 9, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @ewels @mahesh-panchal