Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect indentation on version bump #2514

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Nov 13, 2023

fixes #2206

@mashehu mashehu requested a review from mirpedrol November 13, 2023 11:23
@fabianegli
Copy link
Contributor

fabianegli commented Nov 13, 2023

This PR will prevent me form opening another duplicate of my own issue 🤣

I think it would be great to have a small specific test for that 😉

And I would have gone with capturing the spaces for preservation. Something like this:

                rf"version(\s*)=\s*[\'\"]?{re.escape(current_version)}[\'\"]?",
                rf"version\1= '{new_version}'",

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2514 (acf59c6) into dev (3fddb70) will decrease coverage by 0.04%.
Report is 41 commits behind head on dev.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2514      +/-   ##
==========================================
- Coverage   70.53%   70.50%   -0.04%     
==========================================
  Files          87       88       +1     
  Lines        9456     9519      +63     
==========================================
+ Hits         6670     6711      +41     
- Misses       2786     2808      +22     
Files Coverage Δ
nf_core/bump_version.py 90.76% <100.00%> (+0.29%) ⬆️

... and 13 files with indirect coverage changes

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

@mashehu
Copy link
Contributor Author

mashehu commented Nov 13, 2023

happy now with it, @fabianegli?

@fabianegli
Copy link
Contributor

Very 😄

@mashehu mashehu merged commit ed68cfe into nf-core:dev Nov 13, 2023
19 checks passed
@mashehu mashehu deleted the respect-identation-on-version-bump branch November 13, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants