-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --migrate-pytest option #2549
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #2549 +/- ##
==========================================
+ Coverage 74.88% 75.02% +0.14%
==========================================
Files 85 85
Lines 9222 9271 +49
==========================================
+ Hits 6906 6956 +50
+ Misses 2316 2315 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
default=False, | ||
): | ||
with open(pytest_dir / "main.nf", "r") as fh: | ||
log.info(fh.read()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the Syntax function from rich to add syntax highlighting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, can we make it somehow easier to copy this text? e.g. add it to the pasteboard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to add a new library or take into account different OS.
Also, the important parts to copy over are only the input declarations. I'm not sure if it's worth it copying the whole file to the clipboard.
The current default is to not print the content of this file and not delete it. Do you think this is easier?
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
PR checklist
CHANGELOG.md
is updateddocs
is updated