-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Click TUI with Trogon #2655
Conversation
@ewels, can you please allow me to push to your branch? Tried fixing the merge conflicts in the requirements files |
Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
Should already be allowed? Anyway, I just fixed it 👍🏻 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
@nf-core-bot fix linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Will we be able to replace the pipelines create
from this TUI when it is ready? or is the idea to have them in parallel until we adapt all the other commands?
I don't really know yet. In a perfect world, we would somehow have Trogan as part of the larger TUI framework that we're building. But I'm not sure that this will be possible (very likely not). I just sort of figured that it didn't hurt to add 👀 If we ever get to the point where we have custom TUI interfaces for all commands then we can remove it. I suspect that we will never get there though, and the custom TUI stuff will only be worth investing in for cases where it really adds a lot of value. In which case, this adds a nice halfway-point for all the other commands. Could do with some nice way to switch between custom TUI and Trogan though. Wonder if we could have a button that closes our TUI and launches the Trogan TUI or something 🤔 (so effectively a button to switch). |
Sounds good. Indeed, it doesn't hurt to add it. And we can later try to add this button to switch to Trogan :) |
Add support for Trogon - a TUI for the click CLI interface
CleanShot.2024-01-11.at.15.39.14.mp4