Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Click TUI with Trogon #2655

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Add support for Click TUI with Trogon #2655

merged 4 commits into from
Jan 12, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Jan 11, 2024

Add support for Trogon - a TUI for the click CLI interface

CleanShot.2024-01-11.at.15.39.14.mp4

@ewels ewels requested review from mashehu and mirpedrol January 11, 2024 14:40
@ewels ewels changed the base branch from master to dev January 11, 2024 14:40
@nf-core nf-core deleted a comment from github-actions bot Jan 11, 2024
@mashehu
Copy link
Contributor

mashehu commented Jan 11, 2024

@ewels, can you please allow me to push to your branch? Tried fixing the merge conflicts in the requirements files

Signed-off-by: Phil Ewels <phil.ewels@seqera.io>
@ewels
Copy link
Member Author

ewels commented Jan 11, 2024

@ewels, can you please allow me to push to your branch? Tried fixing the merge conflicts in the requirements files

Should already be allowed?

Anyway, I just fixed it 👍🏻

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed15dd3) 73.10% compared to head (a31fa1f) 73.18%.
Report is 4 commits behind head on dev.

❗ Current head a31fa1f differs from pull request most recent head a616de2. Consider uploading reports for the commit a616de2 to get more accurate results

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu
Copy link
Contributor

mashehu commented Jan 11, 2024

@nf-core-bot fix linting

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Will we be able to replace the pipelines create from this TUI when it is ready? or is the idea to have them in parallel until we adapt all the other commands?

@ewels
Copy link
Member Author

ewels commented Jan 12, 2024

I don't really know yet. In a perfect world, we would somehow have Trogan as part of the larger TUI framework that we're building. But I'm not sure that this will be possible (very likely not).

I just sort of figured that it didn't hurt to add 👀 If we ever get to the point where we have custom TUI interfaces for all commands then we can remove it. I suspect that we will never get there though, and the custom TUI stuff will only be worth investing in for cases where it really adds a lot of value. In which case, this adds a nice halfway-point for all the other commands.

Could do with some nice way to switch between custom TUI and Trogan though. Wonder if we could have a button that closes our TUI and launches the Trogan TUI or something 🤔 (so effectively a button to switch).

@mirpedrol
Copy link
Member

Sounds good. Indeed, it doesn't hurt to add it. And we can later try to add this button to switch to Trogan :)

@ewels ewels merged commit 669be1e into nf-core:dev Jan 12, 2024
32 of 33 checks passed
@ewels ewels deleted the trogon branch January 12, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants