Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundanct v in pipeline version for emails #2667

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

drpatelh
Copy link
Member

Version already contains a v prefix and so removing in email templates:

def prefix_v = workflow.manifest.version[0] != 'v' ? 'v' : ''

@maxulysse
Copy link
Member

I really don't like adding a v prefix for the version, for me the pipeline is pipeline 2.0, not pipeline v2.0

@drpatelh
Copy link
Member Author

I really don't like adding a v prefix for the version, for me the pipeline is pipeline 2.0, not pipeline v2.0

Yeah, I agree. We are somewhat imposing a standard for the prefix to be used like this everywhere which is also partly why we missed this. I only realised after eyeballing the email templates. The version should be vanilla and then we have the option of using whatever prefix we want dependent on the context.

I'll update this in nf-core/fetchngs#252 so when we shift to using these subworkflows in the future as part of the template it will be done already.

@drpatelh
Copy link
Member Author

UPDATE: On the flip-side, I did try to update it in fetchngs but got fed-up of having to put v prefixes everywhere and decided it was a lesser evil. Leave this for later later.

@drpatelh drpatelh merged commit 31c61ca into dev Jan 18, 2024
35 checks passed
@drpatelh drpatelh deleted the email_versions branch January 18, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants