Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules: Fix empty json output for nf-core modules list local #2668

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Modules: Fix empty json output for nf-core modules list local #2668

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
577ac00
fix empty json output for modules list local
mashehu Jan 18, 2024
15fb980
[automated] Update CHANGELOG.md
nf-core-bot Jan 18, 2024
4e8a99c
add tests for json output
mashehu Jan 18, 2024
a791d45
add tests for keyword filtering
mashehu Jan 18, 2024
3912bba
add tests for unknown keywords and wrong repo location
mashehu Jan 18, 2024
b76335a
Merge branch 'dev' into fix-modules-list-json
mashehu Jan 18, 2024
954a033
Merge branch 'dev' into fix-modules-list-json
mashehu Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

### Modules

- Fix empty json output for `nf-core list local` ([#2668](https://github.com/nf-core/tools/pull/2668))

### Subworkflows

### General
Expand Down
1 change: 1 addition & 0 deletions nf_core/components/list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ def pattern_msg(keywords: List[str]) -> str:
date = "[red]Not Available"
message = "[red]Not Available"
table.add_row(component, repo_url, version_sha, message, date)
components.append(component)

if print_json:
return json.dumps(components, sort_keys=True, indent=4)
Expand Down
Loading