Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command nf-core rocrate to create a Research Object (RO) crate for a pipeline #2680

Merged
merged 72 commits into from
Oct 23, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Jan 23, 2024

Example crate from the rnaseq pipeline:

ro-crate-metadata.json

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 65 lines in your changes are missing coverage. Please review.

Comparison is base (31c61ca) 73.41% compared to head (d0e03b1) 73.39%.
Report is 23 commits behind head on dev.

Files Patch % Lines
nf_core/rocrate.py 73.71% 46 Missing ⚠️
nf_core/__main__.py 31.81% 15 Missing ⚠️
nf_core/components/components_command.py 0.00% 4 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu
Copy link
Contributor Author

mashehu commented Jan 24, 2024

@nf-core-bot changelog: Add new command nf-core rocrate to create a Research Object (RO) crate for a pipeline

@mashehu mashehu requested a review from ewels January 24, 2024 16:48
@mashehu mashehu marked this pull request as ready for review January 24, 2024 16:49
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice! 👏🏻

Couple of minor comments and haven't tried running myself, but from a quick run through of the code I think it looks great 👍🏻

nf_core/rocrate.py Outdated Show resolved Hide resolved
self.add_main_authors(wf_file)
wf_file.append_to("programmingLanguage", {"@id": "#nextflow"})
# get keywords from nf-core website
remote_workflows = requests.get("https://nf-co.re/pipelines.json").json()["remote_workflows"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

nf_core/rocrate.py Outdated Show resolved Hide resolved
nf_core/rocrate.py Outdated Show resolved Hide resolved
nf_core/rocrate.py Outdated Show resolved Hide resolved
nf_core/rocrate.py Outdated Show resolved Hide resolved
nf_core/rocrate.py Outdated Show resolved Hide resolved
nf_core/rocrate.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

7 participants