Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: allow ignoring specific files when linting template_strings #2686

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Linting: allow ignoring specific files when linting template_strings #2686

merged 9 commits into from
Jan 29, 2024

Conversation

mirpedrol
Copy link
Member

Close #2581

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@mirpedrol mirpedrol marked this pull request as ready for review January 26, 2024 09:30
mirpedrol
mirpedrol commented Jan 26, 2024
View reviewed changes
nf_core/lint/merge_markers.py Outdated Show resolved Hide resolved
nf_core/lint/merge_markers.py Outdated Show resolved Hide resolved
nf_core/lint/template_strings.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14fdea5) 73.45% compared to head (263b2e0) 73.42%.
Report is 20 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit 93b96d0 into nf-core:dev Jan 29, 2024
36 checks passed
@mirpedrol mirpedrol deleted the lint-ignore-files branch January 29, 2024 09:40
@mirpedrol mirpedrol mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirpedrol @mashehu @nf-core-bot