Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: Add --profile parameter to nf-test command #2767

Merged
merged 7 commits into from
Feb 19, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Feb 16, 2024

fixes #2753

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f016e45) 73.39% compared to head (f4a4c2f) 73.39%.
Report is 34 commits behind head on dev.

Files Patch % Lines
nf_core/components/components_test.py 75.00% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133
Copy link
Member

jfy133 commented Feb 19, 2024

I just tried after installing

pip install --upgrade --force-reinstall git+https://github.com/mashehu/tools.git@nf-test-profiles

But wherever I put the --profile flag after the test subcommand, I still get asked which profile to use.

That I said I do get an error if I leave the flag empty, so it half worked 😅


                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 2.13.dev0 - https://nf-co.re


                                                                                                    
 Usage: nf-core modules test [OPTIONS] <tool> or <tool/subtool>                                     
                                                                                                    
 Try 'nf-core modules test -h' for help                                                             
╭─ Error ──────────────────────────────────────────────────────────────────────────────────────────╮
│ Invalid value for '--profile': 'samtools/cat' is not one of 'docker', 'singularity', 'conda'.    │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
                                                                                                    
$ nf-core modules test --profile conda samtools/cat

                                          ,--./,-.
          ___     __   __   __   ___     /,-._.--~\
    |\ | |__  __ /  ` /  \ |__) |__         }  {
    | \| |       \__, \__/ |  \ |___     \`-._,-`-,
                                          `._,._,'

    nf-core/tools version 2.13.dev0 - https://nf-co.re


? Choose container software to run the test with (Use arrow keys)
 » Docker
   Singularity
   Conda

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as requested, thank you :D

@mashehu mashehu merged commit 706de8f into nf-core:dev Feb 19, 2024
35 checks passed
@mashehu mashehu deleted the nf-test-profiles branch February 19, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants