Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: patch: handle file not found when it is an added file to a module #2771

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

mirpedrol
Copy link
Member

Close #2749

When adding a file to a module, it needs to be patched.
This avoids the file being removed when we update the module.
This PR fixes an error when trying to read a file that doesn't exist during applying patch.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a47369a) 73.44% compared to head (d9bb78a) 73.31%.
Report is 7 commits behind head on dev.

❗ Current head d9bb78a differs from pull request most recent head a24a733. Consider uploading reports for the commit a24a733 to get more accurate results

Files Patch % Lines
nf_core/modules/modules_differ.py 60.00% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mashehu and others added 2 commits February 19, 2024 08:42
Co-authored-by: Júlia Mir Pedrol <mirp.julia@gmail.com>
@maxulysse maxulysse changed the title Moduels: patch: handle file not found when it is an added file to a module Modules: patch: handle file not found when it is an added file to a module Feb 19, 2024
@mirpedrol mirpedrol merged commit fa9ca91 into nf-core:dev Feb 19, 2024
34 checks passed
@mirpedrol mirpedrol deleted the extra-module-file branch February 19, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants