Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove deprecated linters #2795

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

kenibrewer
Copy link
Member

@kenibrewer kenibrewer commented Feb 25, 2024

With the migration of linting functionality out of the core vscode python extension to individual extensions (https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions), these linter paths are no longer needed. In addition, with the adoption of ruff for python formatting & linting, these linters may also be no longer correct in some settings.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated

With the migration of linting functionality out of the core vscode python extension to individual extensions (https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions), these linter paths are no longer needed. In addition, with the adoption of ruff for python formatting & linting, these linters may also be no longer correct in some settings.
@kenibrewer kenibrewer force-pushed the fix/remove-deprecated-linters branch from 5afa49d to a059e16 Compare February 25, 2024 20:51
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (b0a268b) to head (a059e16).

❗ Current head a059e16 differs from pull request most recent head 622601e. Consider uploading reports for the commit 622601e to get more accurate results

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenibrewer kenibrewer marked this pull request as ready for review February 25, 2024 21:19
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, makes sense to me. We should maybe add then ruff to the vs-code extension set (and the gitpod.yml), since this is our default linter for python code.

@kenibrewer
Copy link
Member Author

@mashehu This is my first PR against the tools repo. I couldn't find a CONTRIUBTING.md or documentation section on the website relevant to contributing here. Can you point me towards any instructions I can view?

The specific item I'm confused about is what I need to do in terms of modifying the CHANGELOG.md file.

@mashehu
Copy link
Contributor

mashehu commented Feb 27, 2024

our contributing guidelines here: https://github.com/nf-core/tools/blob/master/.github/CONTRIBUTING.md

we don't have any strict rules for the changelog (actually we have changelog.py which should have run automatically on this, but for some reason skipped this PR 👀 ). I added an entry for your changes. Thanks again for having a look into these settings and extensions!

@kenibrewer
Copy link
Member Author

Thanks @mashehu ! I'm not in the habit of checking .github for the CONTRIBUTING.md file, but know to do so in the future.

@kenibrewer kenibrewer merged commit f64d486 into nf-core:dev Feb 27, 2024
34 checks passed
@kenibrewer kenibrewer deleted the fix/remove-deprecated-linters branch February 27, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants