-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/remove deprecated linters #2795
Fix/remove deprecated linters #2795
Conversation
With the migration of linting functionality out of the core vscode python extension to individual extensions (https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions), these linter paths are no longer needed. In addition, with the adoption of ruff for python formatting & linting, these linters may also be no longer correct in some settings.
5afa49d
to
a059e16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, makes sense to me. We should maybe add then ruff
to the vs-code extension set (and the gitpod.yml), since this is our default linter for python code.
@mashehu This is my first PR against the tools repo. I couldn't find a CONTRIUBTING.md or documentation section on the website relevant to contributing here. Can you point me towards any instructions I can view? The specific item I'm confused about is what I need to do in terms of modifying the CHANGELOG.md file. |
our contributing guidelines here: https://github.com/nf-core/tools/blob/master/.github/CONTRIBUTING.md we don't have any strict rules for the changelog (actually we have |
Thanks @mashehu ! I'm not in the habit of checking |
With the migration of linting functionality out of the core vscode python extension to individual extensions (https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions), these linter paths are no longer needed. In addition, with the adoption of ruff for python formatting & linting, these linters may also be no longer correct in some settings.
PR checklist
CHANGELOG.md
is updated