Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nf-test test instructions to contributing and PR template #2807

Merged
merged 2 commits into from
Feb 29, 2024
Merged

add nf-test test instructions to contributing and PR template #2807

merged 2 commits into from
Feb 29, 2024

Conversation

sateeshperi
Copy link
Contributor

adding instructions to run all tests to contributing with debug and also update PR template with nf-test instructions

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@sateeshperi sateeshperi mentioned this pull request Feb 28, 2024
Merged
mashehu
mashehu approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have the tools commands for pipelines yet, so ignore my comments

@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (145fa48) to head (f7d7f0b).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sateeshperi sateeshperi merged commit e11bbbb into dev Feb 29, 2024
35 checks passed
@sateeshperi sateeshperi deleted the feat/add-nf-test-run-debug-instructions branch February 29, 2024 04:58
@sateeshperi sateeshperi restored the feat/add-nf-test-run-debug-instructions branch February 29, 2024 04:58
@sateeshperi sateeshperi deleted the feat/add-nf-test-run-debug-instructions branch February 29, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sateeshperi @mashehu