Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting params in main.nf #2838

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Mar 11, 2024

#2833. Trying to only match assignments of params in main.nf and not references like, for instance, params.aligner == "bwa-mem".

I tested this solution locally on this version of Sarek.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@asp8200 asp8200 changed the base branch from master to dev March 11, 2024 10:51
@nf-core nf-core deleted a comment from github-actions bot Mar 11, 2024
@nf-core nf-core deleted a comment from github-actions bot Mar 11, 2024
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@asp8200 asp8200 marked this pull request as ready for review March 11, 2024 12:13
@asp8200 asp8200 merged commit d4e5243 into nf-core:dev Mar 11, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants