Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for assignment and referencing of params in main.nf #2841

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Add tests for assignment and referencing of params in main.nf #2841

merged 5 commits into from
Mar 13, 2024

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Mar 12, 2024 •
edited
Loading

Trying to add some tests for the bug reported in #2833.

I locally tested that the test test_allow_params_reference_in_main_nf fails (as desired) with the former regexp which caused the bug #2833.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@asp8200 asp8200 marked this pull request as ready for review March 12, 2024 10:56
mirpedrol
mirpedrol reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these tests!!
It is looking good :) The only thing to take into account is that we shouldn't modify the original pipeline template but only modify files within the tests.

nf_core/pipeline-template/main.nf Outdated Show resolved Hide resolved
tests/lint/nextflow_config.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.78%. Comparing base (9f78a5e) to head (b079de9).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asp8200 asp8200 requested a review from mirpedrol March 12, 2024 15:13
mirpedrol
mirpedrol approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@asp8200
Copy link
Contributor Author

asp8200 commented Mar 13, 2024

LGTM, thank you :)

Thanks for the help on this. Happy to contribute 🙂

@asp8200 asp8200 merged commit 47f18ea into nf-core:dev Mar 13, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asp8200 @mirpedrol @nf-core-bot @mashehu