Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template according to new specification #2985

Merged
merged 5 commits into from
May 22, 2024

Conversation

famosab
Copy link
Contributor

@famosab famosab commented May 15, 2024

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

I updated the modules template according to this PR. This way of handing the test data was enforced during the march 2024 hackathon and I thought it should be reflected in the template 😄

Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @famosab,

It looks like this pull-request is has been made against the famosab/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the famosab/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@maxulysse maxulysse changed the base branch from master to dev May 15, 2024 12:23
@maxulysse
Copy link
Member

Can you add a CHANGELOG entry in the TEMPLATE section

@famosab
Copy link
Contributor Author

famosab commented May 15, 2024

How excatly do I need to add this? as a new patch?

CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member

How excatly do I need to add this? as a new patch?

No need to worry about that, you were based on master, the tag was on dev

@famosab
Copy link
Contributor Author

famosab commented May 15, 2024

There is still one check failing ... :(

@maxulysse
Copy link
Member

@mirpedrol any idea?

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing test was due to a Docker error, it is fixed now, I re-run the tests so it should be ok once they finish running

@famosab
Copy link
Contributor Author

famosab commented May 22, 2024

@mirpedrol Still one test: test_components with 3.8 which is failing :(

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.19%. Comparing base (e6b089b) to head (5fc3069).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol
Copy link
Member

All green now ✅ thanks!

@mirpedrol mirpedrol merged commit 2036bb7 into nf-core:dev May 22, 2024
36 checks passed
@famosab famosab deleted the module-template-update branch May 22, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants