-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update template according to new specification #2985
Conversation
This PR is against the
|
Can you add a CHANGELOG entry in the TEMPLATE section |
How excatly do I need to add this? as a new patch? |
No need to worry about that, you were based on master, the tag was on dev |
There is still one check failing ... :( |
@mirpedrol any idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing test was due to a Docker error, it is fixed now, I re-run the tests so it should be ok once they finish running
@mirpedrol Still one test: test_components with 3.8 which is failing :( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
All green now ✅ thanks! |
PR checklist
CHANGELOG.md
is updateddocs
is updatedI updated the modules template according to this PR. This way of handing the test data was enforced during the march 2024 hackathon and I thought it should be reflected in the template 😄