Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda module linting: Include package name in log file #3014

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented May 31, 2024

Tried to do this with GitHub Copilot Workspaces but it failed 😅

As I was looking at the code anyway I could see the fix so figured I would put it manually.

Closes #3009

Untested, done in web browser only.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Tried to do this with GitHub Copilot Workspaces but it failed 😅 

As I was looking at the code anyway I could see the fix so figured I would put it manually.

Closes #3009

Untested, done in web browser only.
@ewels ewels requested a review from mirpedrol May 31, 2024 21:35
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.16%. Comparing base (d7ce41b) to head (847a376).
Report is 7 commits behind head on dev.

Files Patch % Lines
nf_core/modules/lint/main_nf.py 0.00% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mirpedrol
Copy link
Member

@nf-core-bot changelog

@mirpedrol mirpedrol merged commit 14f0da4 into dev Jun 3, 2024
36 checks passed
@mirpedrol mirpedrol deleted the lint-conda-name-in-log branch June 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants