Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated syntax #3046

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Remove deprecated syntax #3046

merged 4 commits into from
Jul 3, 2024

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels
Copy link
Member

ewels commented Jul 3, 2024

From the Nextflow docs:

In Nextflow versions prior to 22.03.0-edge, you must enable DSL2 explicitly in order to use it. You can either set the feature flag in your pipeline script:

nextflow.enable.dsl=2

So as long as we are specifying a minimum version above that it should be good to remove.

@maxulysse
Copy link
Member Author

From the Nextflow docs:

In Nextflow versions prior to 22.03.0-edge, you must enable DSL2 explicitly in order to use it. You can either set the feature flag in your pipeline script:

nextflow.enable.dsl=2

So as long as we are specifying a minimum version above that it should be good to remove.

https://github.com/nf-core/tools/blob/dsl2_enabled/nf_core/pipeline-template/nextflow.config#L261

@maxulysse
Copy link
Member Author

@mirpedrol any idea about the failures?

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (53a04db) to head (6dd57df).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirpedrol mirpedrol merged commit 9f0d251 into dev Jul 3, 2024
35 checks passed
@mirpedrol mirpedrol deleted the dsl2_enabled branch July 3, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants