Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Params linting #310

Closed
wants to merge 12 commits into from
Closed

Params linting #310

wants to merge 12 commits into from

Conversation

sven1103
Copy link
Member

@sven1103 sven1103 commented Apr 10, 2019

Related issue: #267

  • Add parameters.settings.json file
  • Generate --help message based on params file
  • Check for valid parameters.settings.json file
  • Check for parameters during markdown linting

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md

@KochTobi KochTobi added the WIP Work in progress label Apr 10, 2019
add check for file exists `parameters.settings.json`
add check for valid JSON format
@ewels

This comment has been minimized.

@KochTobi
Copy link

I thought about using the content of the json file and checking it against the structure that should be present int a parameters.settings.json file. But I don't think that I will have time to implement it so I removed it again.

@ewels
Copy link
Member

ewels commented Feb 14, 2021

We've come a long way! Now being implemented in #852

@ewels ewels closed this Feb 14, 2021
@ewels ewels deleted the paramsLinting branch February 14, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants