Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run nf-core lint --release on PRs to master #3148

Merged
merged 5 commits into from
Sep 6, 2024
Merged

run nf-core lint --release on PRs to master #3148

merged 5 commits into from
Sep 6, 2024

Conversation

mirpedrol
Copy link
Member

Close #3144

ewels and others added 2 commits September 6, 2024 17:07
@ewels @muffato
Don't look for dev, look for not master
6b3e848 
Co-authored-by: Matthieu Muffato <cortexspam-github@yahoo.fr>
@ewels
Move if statements to top of YAML blocks
3e020cf
ewels
ewels approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't let those if statements sit at the end like that sorry, so I moved them up 👀

Otherwise LGTM! Thanks!

@ewels ewels enabled auto-merge September 6, 2024 15:09
@ewels ewels linked an issue Sep 6, 2024 that may be closed by this pull request
Release PR (dev to master) does not fail with a pipeline still on dev version #3144
Closed
@ewels ewels merged commit 8e47a33 into nf-core:dev Sep 6, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muffato muffato muffato left review comments

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release PR (dev to master) does not fail with a pipeline still on dev version
3 participants
@mirpedrol @ewels @muffato