Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --dir/-d option to schema commands #3247

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Oct 24, 2024

Fixes #3234
not sure if we want it also in pipelines create

@mashehu mashehu requested a review from mirpedrol October 24, 2024 09:30
@mirpedrol
Copy link
Member

We already have the option for pipelines create, but on the CLI is called --outdir/-o, we could rename it or better, allow both notations.
image

@mashehu
Copy link
Contributor Author

mashehu commented Oct 24, 2024

yeah, was actually thinking the same, only problem is that -d is used for description, so I think it is okay, to have that as an exemption, or what do you think, @nschan?

@mashehu mashehu requested a review from nschan October 24, 2024 09:51
@nschan
Copy link
Contributor

nschan commented Oct 24, 2024

Personally, I think -o for create is reasonable. I understand -d to mean "run inside dir" whereas -o is output.

Copy link
Contributor

@nschan nschan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashehu mashehu merged commit d59ac3f into nf-core:dev Oct 24, 2024
83 checks passed
@mashehu mashehu deleted the add-dir-to-schema-commands branch October 24, 2024 14:17
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.30%. Comparing base (b87106d) to head (f49e9cf).
Report is 86 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/__main__.py 72.72% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants