Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template: Add resource limits to Gitpod profile #3255

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

mahesh-panchal
Copy link
Member

Adds resource limits to Gitpod

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Copy link
Contributor

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @mahesh-panchal,

It looks like this pull-request is has been made against the mahesh-panchal/nf-core-tools main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the mahesh-panchal/nf-core-tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@mahesh-panchal mahesh-panchal changed the base branch from main to dev October 28, 2024 15:26
@mirpedrol mirpedrol changed the title Add resource limits to Gitpod profile Template: Add resource limits to Gitpod profile Oct 29, 2024
@mirpedrol
Copy link
Member

@nf-core-bot changelog

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Could you please update the CHANGELOG.md if the bot doesn't do it? thanks!

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.34%. Comparing base (eb4c237) to head (fc778f3).
Report is 14 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahesh-panchal
Copy link
Member Author

Changelog updated

@mashehu mashehu merged commit 04bbf4a into nf-core:dev Oct 31, 2024
84 checks passed
@mahesh-panchal mahesh-panchal deleted the add_gitpod_resource_limits branch October 31, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants