create template GENERATE_DOWNSTREAM_SAMPLESHEETS for tools #3261
+339
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joon-Klaps
changed the title
This commit refactors the generate_downstream_samplesheets subworkflow in the pipeline-template. It updates the workflow to a specific pipeline and adds support for more pipelines in the future. The changes include modifying the input parameters and updating the channelToSamplesheet function. This refactoring improves the flexibility and extensibility of the subworkflow.
mashehu
reviewed
Oct 30, 2024
| {% if downstream_samplesheets -%} | ||
| // Downstream samplesheets | ||
| generate_downstream_samplesheets = true | ||
| generate_pipeline_samplesheets = 'rnaseq' |
There was a problem hiding this comment.
do we need to have that as a default?
There was a problem hiding this comment.
It think we need to add more TODO statemetns next to this, I'm in two minds whether we should put an example or empty.
The whole thing might not be immediately obvious how to adapt without the example. For example I would actually extend the example to comma separated list as this is supported.
There was a problem hiding this comment.
@jfy133 I like that idea. But we should be carefull not to make it to complex.
nf_core/pipeline-template/subworkflows/local/generate_downstream_samplesheets/main.nf
Outdated
Show resolved
Hide resolved
Comment on lines
18
to
25
| ch_list_for_samplesheet = ch_reads.map { meta, reads -> | ||
| def out_path = file(params.outdir).toString() + '/relative/custom/path/' | ||
| def sample = meta.id | ||
| def fastq_1 = meta.single_end ? out_path + reads.getName() : out_path + reads[0].getName() | ||
| def fastq_2 = !meta.single_end ? out_path + reads[1].getName() : "" | ||
| def strandedness = "auto" | ||
| [sample: sample, fastq_1: fastq_1, fastq_2: fastq_2, strandedness: strandedness] | ||
| } |
There was a problem hiding this comment.
are we sure we want it to make so genomics specific?
There was a problem hiding this comment.
See reply above about pros/cons of example code (maybe with more TODOs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Solves #3259
CHANGELOG.mdis updateddocsis updated