Fix #85 #475
Merged
Fix #85 #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewels
reviewed
Dec 6, 2019
ewels
requested changes
Dec 6, 2019
ewels
approved these changes
Dec 6, 2019
|
|
@apeltzer yeah , saw that. I will fix it at the airport or tomorrow morning :) |
Pipeline name is not set in PipelineLint object, but initialized with 'None'. It is set in function check_nextflow_config. To test the function check_pipeline_name by itself, I set the name manually.
apeltzer
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#85
Linting now checks whether the pipeline name only contains lower case & alphabetical characters. Otherwise a warning is displayed.
For that the minimal_working_example was renamed to minimalworkingexample
PR checklist
docsis updatedCHANGELOG.mdis updatedREADME.mdis updatedLearn more about contributing: https://github.com/nf-core/tools/tree/master/.github/CONTRIBUTING.md