Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scrape_software_versions for python3 #476

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Fix scrape_software_versions for python3 #476

merged 2 commits into from
Dec 6, 2019

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Dec 6, 2019

Make it Python3 compatible following @drpatelh lead on this!

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Fixes requirements for #462

@apeltzer apeltzer requested a review from a team December 6, 2019 12:58
@apeltzer apeltzer mentioned this pull request Dec 6, 2019
Merged
ewels
ewels approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 👍

@ewels ewels merged commit 89c9f6e into nf-core:dev Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewels ewels ewels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeltzer @ewels