-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync matrix #716
Sync matrix #716
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #716 +/- ##
==========================================
+ Coverage 81.92% 83.04% +1.11%
==========================================
Files 13 13
Lines 2766 2748 -18
==========================================
+ Hits 2266 2282 +16
+ Misses 500 466 -34
Continue to review full report at Codecov.
|
Manual test with methylseq worked: nf-core/methylseq#165 (no existing PR) |
Manual test with ampliseq also worked! nf-core/ampliseq#134 (comment) (existing PR updated) |
Just tested again manually with methylseq and ampliseq, in addition to mag earlier with the fixed 404s. All looking good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! LGTM!
Refactored sync code:
Still TODO:
PR checklist
CHANGELOG.md
is updateddocs
is updated