Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync matrix #716

Merged
merged 21 commits into from
Jul 31, 2020
Merged

Sync matrix #716

merged 21 commits into from
Jul 31, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Jul 31, 2020

Refactored sync code:

Still TODO:

  • Update tests for new sync code
  • Run manual sync commands on pipelines with and without existing template PRs to check that it works in real life

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels added WIP Work in progress high-priority labels Jul 31, 2020
@ewels ewels self-assigned this Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #716 into dev will increase coverage by 1.11%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #716      +/-   ##
==========================================
+ Coverage   81.92%   83.04%   +1.11%     
==========================================
  Files          13       13              
  Lines        2766     2748      -18     
==========================================
+ Hits         2266     2282      +16     
+ Misses        500      466      -34     
Impacted Files Coverage Δ
nf_core/__main__.py 62.92% <40.00%> (+1.10%) ⬆️
nf_core/sync.py 75.52% <77.35%> (+12.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f92ef...ee5c010. Read the comment docs.

@ewels
Copy link
Member Author

ewels commented Jul 31, 2020

Manual test with methylseq worked: nf-core/methylseq#165 (no existing PR)

@ewels
Copy link
Member Author

ewels commented Jul 31, 2020

Manual test with ampliseq also worked! nf-core/ampliseq#134 (comment) (existing PR updated)

@ewels ewels marked this pull request as ready for review July 31, 2020 09:20
@ewels ewels removed the WIP Work in progress label Jul 31, 2020
@ewels ewels requested a review from a team July 31, 2020 09:21
@ewels
Copy link
Member Author

ewels commented Jul 31, 2020

Just tested again manually with methylseq and ampliseq, in addition to mag earlier with the fixed 404s. All looking good!

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants