Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging - force colours if certain env vars are set. #760

Merged
merged 4 commits into from
Nov 5, 2020
Merged

Logging - force colours if certain env vars are set. #760

merged 4 commits into from
Nov 5, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Nov 5, 2020 •
edited
Loading

Should hopefully make GitHub Actions logs show coloured output. Especially useful for nf-core lint results.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • Added new tests

@ewels ewels added the command line tools Anything to do with the cli interfaces label Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020 •
edited
Loading

Codecov Report

Merging #760 into dev will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #760      +/-   ##
==========================================
+ Coverage   82.99%   83.02%   +0.02%     
==========================================
  Files          13       13              
  Lines        2747     2751       +4     
==========================================
+ Hits         2280     2284       +4     
  Misses        467      467
Impacted Files Coverage Δ
nf_core/launch.py 70.94% <0.00%> (ø)
nf_core/__main__.py 62.92% <100.00%> (ø)
nf_core/lint.py 91.10% <100.00%> (ø)
nf_core/utils.py 91.36% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f02340...e9d7c86. Read the comment docs.

@ewels ewels requested a review from a team November 5, 2020 11:34
@ewels
Copy link
Member Author

ewels commented Nov 5, 2020

Works! 🤩

https://github.com/nf-core/tools/runs/1357970045#step:6:42

image

drpatelh
drpatelh approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boyaaaaaa!

@ewels ewels merged commit 99bdd29 into nf-core:dev Nov 5, 2020
@ewels ewels deleted the githubactions-color branch November 5, 2020 11:44
@ewels ewels mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
command line tools Anything to do with the cli interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewels @drpatelh